epugh commented on code in PR #4264:
URL: https://github.com/apache/solr/pull/4264#discussion_r3106090287
##########
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java:
##########
@@ -182,6 +182,11 @@ public void uploadFileToConfig(
}
if (overwriteOnExists || !Files.exists(configsetFilePath)) {
+ // Create parent directories if they don't exist (similar to ZK's
makePath)
Review Comment:
I added it because if you put a single file in standalone, and the dire
doesn't already exist, tjhen it breatks. so it felt easy to fix that up.
And simpliefed the docs explationa!
Right abot these lines are:
```
if (!FileUtils.isPathAChildOfParent(
configsetBasePath, configsetFilePath)) { // See SOLR-17543 for
context
log.warn(
"Not uploading file [{}], as it resolves to a location [{}]
outside of the configset root directory [{}]",
fileName,
configsetFilePath,
configsetBasePath);
return;
```
However, since I don't use standalone, and don't need the capablity, I'm
probably okay just removing it and adding a note about missing directories not
being created on the fly......
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
