epugh commented on code in PR #4264:
URL: https://github.com/apache/solr/pull/4264#discussion_r3106990963
##########
solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPI.java:
##########
@@ -765,15 +735,9 @@ private void testNewSingleFileAfterSchemaAPI(boolean v2)
throws Exception {
zkClient, configsetName, configsetSuffix,
"test/upload/path/solrconfig.xml"));
}
- @Test
- public void testSingleWithCleanupV1() throws Exception {
- testSingleWithCleanup(false);
- }
+ // Single file uploads do not support cleanup parameter
- @Test
- public void testSingleWithCleanupV2() throws Exception {
- testSingleWithCleanup(true);
- }
+ // V2 API not tested: single file uploads do not support cleanup parameter
Review Comment:
correct, and simplified and fixed... thanks. This whole test is all kind
of just "icky"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
