epugh commented on code in PR #4264:
URL: https://github.com/apache/solr/pull/4264#discussion_r3106984679
##########
solr/core/src/java/org/apache/solr/handler/configsets/UploadConfigSet.java:
##########
@@ -108,27 +109,20 @@ public SolrJerseyResponse uploadConfigSet(
@Override
@PermissionName(CONFIG_EDIT_PERM)
- public SolrJerseyResponse uploadConfigSetFile(
- String configSetName,
- String filePath,
- Boolean overwrite,
- Boolean cleanup,
- InputStream requestBody)
- throws IOException {
+ public SolrJerseyResponse putConfigSetFile(
+ String configSetName, String filePath, InputStream requestBody) throws
IOException {
final var response = instantiateJerseyResponse(SolrJerseyResponse.class);
ensureConfigSetUploadEnabled();
SolrIdentifierValidator.validateConfigSetName(configSetName);
- boolean overwritesExisting =
configSetService.checkConfigExists(configSetName);
+ boolean overwrite = true;
Review Comment:
so, to reduce churn in the api, this is set to overwrite true, and then used
in `configSetService.uploadFileToConfig`. however, there are other places,
like BackupManager where the value is false, so I can't just remove the
variable and just make it always a overwritting operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
