epugh commented on code in PR #4264:
URL: https://github.com/apache/solr/pull/4264#discussion_r3106996898
##########
solr/core/src/test/org/apache/solr/handler/configsets/GetConfigSetFileAPITest.java:
##########
@@ -114,8 +120,11 @@ public void testFileNotFoundInConfigSetThrowsNotFound()
throws Exception {
Files.createDirectories(configSetBase.resolve(configSetName));
final var api = new GetConfigSetFile(mockCoreContainer, null, null);
- final var ex =
- assertThrows(SolrException.class, () ->
api.getConfigSetFile(configSetName, "missing.xml"));
+ final StreamingOutput streamingOutput =
api.getConfigSetFile(configSetName, "missing.xml");
Review Comment:
so, there is a 404, but it happens furthu down when we actually go write the
content, so at this point it's like we just have a pointer, we don't actually
know tha thte file is missing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
