serhiy-bzhezytskyy opened a new pull request, #4613: URL: https://github.com/apache/solr/pull/4613
**Draft, for review — part 2 of 3.** Builds on #4612 (which must merge first). Applies DAGP's `implementation -> api` advice **only** for the ~36 inter-module `project(...)` dependencies where the type is genuinely part of the consuming module's public API — e.g. `:solr:core` publicly exposes `:solr:solrj` types, so `api` is correct and downstream modules compile against them. The ~91 **external-library** api promotions DAGP also suggests are deliberately **not** here — see part 3/3 (draft, not for merge), which shows them for discussion. Per @dsmiley's point that DAGP is "api-happy" and liberal `api` is viral/transitive, those need case-by-case judgement. `gradlew check -x test` passes. AI-assisted, human-reviewed per AGENTS.md. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
