dsmiley commented on code in PR #4613:
URL: https://github.com/apache/solr/pull/4613#discussion_r3544739907
##########
solr/cross-dc-manager/build.gradle:
##########
@@ -24,10 +24,10 @@ description = 'Cross-DC Manager'
dependencies {
implementation platform(project(':platform'))
- implementation project(':solr:core')
- implementation project(':solr:solrj')
+ api project(':solr:core')
+ api project(':solr:solrj')
Review Comment:
It's confusing to me why solrj is listed here at all (whatever configuration
scope). solr-core has an "api" config dependency on solrj... thus this means
solrJ is exposed at equivalent scope to whoever consumed solr-core. The
subproject here is depending on solr-core... so then why also mention solrj at
all?
What I'm talking about is probably tangential to this PR because you didn't
change the scopes I'm talking about. Note that many of our dependency
declarations are redundant due to cutterslade not understanding the nuance of
gradle's "api". I'm hoping we can remove these redundant declarations and
maybe the dagp thing you are adding could help us identify redundancies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
