serhiy-bzhezytskyy commented on code in PR #4613:
URL: https://github.com/apache/solr/pull/4613#discussion_r3544974478
##########
solr/cross-dc-manager/build.gradle:
##########
@@ -24,10 +24,10 @@ description = 'Cross-DC Manager'
dependencies {
implementation platform(project(':platform'))
- implementation project(':solr:core')
- implementation project(':solr:solrj')
+ api project(':solr:core')
+ api project(':solr:solrj')
Review Comment:
Good question, and it's actually the opposite of redundant here —
cross-dc-manager uses solrj directly (CloudSolrClient, UpdateRequest,
SolrRequest, etc. in ~4 files), so declaring it is the right call rather than
leaning on the transitive `api` from core. The Gradle guidance is "declare what
you use directly," so you don't break when core's internals shift.
And yeah — DAGP is exactly the tool for what you're after. It flags both
directions: unused declarations you can drop, *and* transitives you use
directly but haven't declared. For this one it agrees with keeping solrj
(doesn't flag it for removal). So it should help find the genuinely-redundant
cutterslade leftovers without touching the legit direct declarations.
Happy to do a pass on the redundant ones as a follow-up if useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
