dsmiley commented on code in PR #4613:
URL: https://github.com/apache/solr/pull/4613#discussion_r3545114265
##########
solr/cross-dc-manager/build.gradle:
##########
@@ -24,10 +24,10 @@ description = 'Cross-DC Manager'
dependencies {
implementation platform(project(':platform'))
- implementation project(':solr:core')
- implementation project(':solr:solrj')
+ api project(':solr:core')
+ api project(':solr:solrj')
Review Comment:
We agree there's a judgement call to make a dependency "api" instead of
"implementation"; we're not doing it willy-nilly or simply because some tool
found one public API signature using the dependency. If we are diligent about
this (I think we are), then why not rely on this judgement on the consuming end
to not be redundant? Otherwise, what's the point of "api" at all if we don't
take advantage of it.
Case in point: There's no way in hell that SolrJ will stop being a
dependency of Solr-core. Any consumer of solr-core will consume solrJ. Even
if for some other example where it'a "api" today but we change our mind... well
so what? Consumer will find out (won't compile) and add the dependency
explicitly then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
