serhiy-bzhezytskyy commented on code in PR #4613:
URL: https://github.com/apache/solr/pull/4613#discussion_r3545412251
##########
solr/cross-dc-manager/build.gradle:
##########
@@ -24,10 +24,10 @@ description = 'Cross-DC Manager'
dependencies {
implementation platform(project(':platform'))
- implementation project(':solr:core')
- implementation project(':solr:solrj')
+ api project(':solr:core')
+ api project(':solr:solrj')
Review Comment:
Strong agree that human expert over tool... dagp won't help find these
though — it goes by "declare what you use", so it'd keep solrj in cross-dc, not
flag it. that redundancy is our judgement, not the tool's. can take a manual
pass at the leftovers if useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
