dsmiley commented on code in PR #4607:
URL: https://github.com/apache/solr/pull/4607#discussion_r3538920192
##########
solr/modules/sql/src/test/org/apache/solr/handler/sql/TestSQLHandler.java:
##########
@@ -452,6 +452,61 @@ public void testBasicSelect() throws Exception {
tuples = getTuples(sParams, baseUrl);
assertEquals(0, tuples.size());
+
+ // Verify that unrelated request parameters are ignored
+ sParams =
+ params(
+ CommonParams.QT,
+ "/sql",
+ "someOtherParam",
+ "someValue",
Review Comment:
your assertions don't check that "someOtherParam" wasn't passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
