janhoy commented on code in PR #4607:
URL: https://github.com/apache/solr/pull/4607#discussion_r3667455821
##########
solr/modules/sql/src/java/org/apache/solr/handler/sql/SQLHandler.java:
##########
@@ -85,8 +102,6 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
String sql = params.get("stmt");
// Set defaults for parameters
params.set("numWorkers", params.getInt("numWorkers", 1));
- params.set("workerCollection", params.get("workerCollection",
defaultWorkerCollection));
Review Comment:
Good question — I checked: no. These params lost their only consumer back in
the SOLR-8593 refactoring (37fdc37fc3d, Solr 6.4, Dec 2016), when `SolrTable`
switched to building `ParallelStream(solrConnection, collection, ...)` from the
connection and queried collection directly. Since then SQLHandler has been
setting `workerCollection`/`workerZkhost` into the request with no reader. A
repo-wide grep finds no tests or docs referencing them — the only hits are the
unrelated `parallel()` streaming-expression examples in the ref guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
