janhoy commented on code in PR #4607:
URL: https://github.com/apache/solr/pull/4607#discussion_r3667444734
##########
solr/modules/sql/src/test/org/apache/solr/handler/sql/TestSQLHandler.java:
##########
@@ -452,6 +452,61 @@ public void testBasicSelect() throws Exception {
tuples = getTuples(sParams, baseUrl);
assertEquals(0, tuples.size());
+
+ // Verify that unrelated request parameters are ignored
+ sParams =
+ params(
+ CommonParams.QT,
+ "/sql",
+ "someOtherParam",
+ "someValue",
Review Comment:
That's because unknown ones are simply dropped, hard to verify in an
integration test.
I changed it to pass a **real** param `schemaType` which is not in the
default set and is thus ignored, then we test afterwards that when that param
is in the allowlist with an invalid value, calcite barfs and there is an
exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
