epugh commented on code in PR #4607:
URL: https://github.com/apache/solr/pull/4607#discussion_r3539001688
##########
solr/modules/sql/src/java/org/apache/solr/handler/sql/SQLHandler.java:
##########
@@ -52,10 +53,27 @@ public class SQLHandler extends RequestHandlerBase
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
private static String defaultZkhost = null;
- private static String defaultWorkerCollection = null;
static final String sqlNonCloudErrorMsg = "/sql handler only works in Solr
Cloud mode";
+ /** System property to override the set of request parameters forwarded to
Calcite. */
+ static final String ALLOWED_CONNECTION_PARAMS_PROP =
"solr.sql.connection.params.allowed";
+
+ /** Calcite configuration parameters forwarded as connection properties. */
+ static final Set<String> DEFAULT_CONNECTION_PARAMS =
Review Comment:
assuming these are the right ones! Wow...
##########
solr/solr-ref-guide/modules/configuration-guide/pages/solr-properties.adoc:
##########
Review Comment:
nice to see this expanding to cover more (and covering new properties!)
##########
solr/modules/sql/src/java/org/apache/solr/handler/sql/SQLHandler.java:
##########
@@ -85,8 +102,6 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
String sql = params.get("stmt");
// Set defaults for parameters
params.set("numWorkers", params.getInt("numWorkers", 1));
- params.set("workerCollection", params.get("workerCollection",
defaultWorkerCollection));
Review Comment:
were there any tests that could be removed when these params were removed???
I didn't look...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
