janhoy commented on code in PR #4607: URL: https://github.com/apache/solr/pull/4607#discussion_r3667390758
########## solr/modules/sql/src/java/org/apache/solr/handler/sql/SQLHandler.java: ########## @@ -52,10 +53,27 @@ public class SQLHandler extends RequestHandlerBase private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); private static String defaultZkhost = null; - private static String defaultWorkerCollection = null; static final String sqlNonCloudErrorMsg = "/sql handler only works in Solr Cloud mode"; + /** System property to override the set of request parameters forwarded to Calcite. */ + static final String ALLOWED_CONNECTION_PARAMS_PROP = "solr.sql.connection.params.allowed"; + + /** Calcite configuration parameters forwarded as connection properties. */ + static final Set<String> DEFAULT_CONNECTION_PARAMS = Review Comment: Yea, it's a carefully selected set, much better to be explicit than a pure pass-through. And the sysprop gives advanced users a way to do customize. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
