On Wed, Nov 20, 2019 at 2:33 PM Oliver Gondža <[email protected]> wrote: > Even when we would be be able to compensate now in the plugin, > because that would leave several JCasC versions available that are known > to be broken on newer cores.
So just mention in the upgrade guide that you need to update the `configuration-as-code` plugin (preferably before the core upgrade)? > asserting JENKINS-58993 violation only during unit tests I.e., using Java assertions, which should be enabled during tests and not (normally) enabled in production. Fine from my PoV if you want to do that in the `stable-2.204` branch so long as it remains a hard fail in `master`. This should serve as a reminder that the Jenkins weekly release process should run PCT against an ever-growing selection of plugins, and failures should be considered release blockers, or we could even do this daily (making it part of the PR builder would likely be too expensive). Requires someone to commit to setting up and maintaining that infrastructure. The `jenkinsci/bom` Dependabot builds catch some plugin regressions but this is not set up well for catching core regressions. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1%3DAFixJ0o5AKgN6cO-oqkSe4c86BUBO2XaVzmTsZjNjQ%40mail.gmail.com.
