I get what you say, James. My point being we ware shipping a core with this flaw for years (correct me if I wrong), there ware no documentation plugins should not save before EXTENSIONS_AUGMENTED is completed and people ware not bitten severely enough to file an issue until recently (again, correct me if I a wrong). So from this standpoint, I see the claim that "no level of dataloss is acceptable" (while breaking JCasC users) a bit, for the lack of better word, fundamentalistic. All I am after here is to find the reasonable balance between the added safety of your fix and the impact on the JCasC customers.

So for now, it seems to me the most of the folks lean towards shipping the fix the way it is and documenting eventual consequences.

Are we ok to see how the JCasC PR is doing before committing to an LTS baseline?

On 21/11/2019 11.38, James Nord wrote:
I will state this again -*no level of dataloss is acceptable* - we should not back this change out or make it disabled by default.

There is a drive by untested PR to Configuration As Code plugin if someone wants to look at it.

https://github.com/jenkinsci/configuration-as-code-plugin/pull/1204

/James

On Thursday, November 21, 2019 at 7:51:39 AM UTC, ogondza wrote:

    I like that idea, Jesse. Can we agree on picking 2.204 with
    JENKINS-58993 patched to only fail when assertions are on?

    --
    oliver

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected] <mailto:[email protected]>. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/3588ff14-54bc-4d6e-99c8-1144bc502683%40googlegroups.com <https://groups.google.com/d/msgid/jenkinsci-dev/3588ff14-54bc-4d6e-99c8-1144bc502683%40googlegroups.com?utm_medium=email&utm_source=footer>.


--
oliver

--
You received this message because you are subscribed to the Google Groups "Jenkins 
Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/285c28ec-53ef-4dfe-3b3a-8526c63b3920%40gmail.com.

Reply via email to