showuon commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1024726967
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##########
@@ -162,6 +162,17 @@ private boolean allSubscriptionsEqual(Set<String>
allTopics,
return isAllSubscriptionsEqual;
}
+ // visible for testing
+ MemberData memberDataFromSubscription(Subscription subscription) {
+ if (!subscription.ownedPartitions().isEmpty() &&
subscription.generationId().isPresent()) {
Review Comment:
> For instance, this could happen if the group has more members than
partitions.
In that case, the `subscription.generationId()` should still contain valid
number. Is that right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
