showuon commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1024795520
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##########
@@ -162,6 +162,17 @@ private boolean allSubscriptionsEqual(Set<String>
allTopics,
return isAllSubscriptionsEqual;
}
+ // visible for testing
+ MemberData memberDataFromSubscription(Subscription subscription) {
+ if (!subscription.ownedPartitions().isEmpty() &&
subscription.generationId().isPresent()) {
Review Comment:
I know what you mean now. Yes, for `subscription v3` check, we should only
check generationId. Will update it and add a test for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
