jolshan commented on code in PR #14444:
URL: https://github.com/apache/kafka/pull/14444#discussion_r1348126229
##########
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java:
##########
@@ -65,24 +67,41 @@ public ProduceResponse(ProduceResponseData
produceResponseData) {
/**
* Constructor for Version 0
+ * This is deprecated in favor of using the ProduceResponseData
constructor, KafkaApis should switch to that
+ * in KAFKA-10730
* @param responses Produced data grouped by topic-partition
*/
@Deprecated
public ProduceResponse(Map<TopicPartition, PartitionResponse> responses) {
- this(responses, DEFAULT_THROTTLE_TIME);
+ this(responses, DEFAULT_THROTTLE_TIME, Collections.emptyList());
}
/**
- * Constructor for the latest version
+ * Constructor for versions <= 9
+ * This is deprecated in favor of using the ProduceResponseData
constructor, KafkaApis should switch to that
+ * in KAFKA-10730
Review Comment:
I don't think this comment is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
