jolshan commented on code in PR #14444: URL: https://github.com/apache/kafka/pull/14444#discussion_r1348136534
########## clients/src/main/resources/common/message/ProduceResponse.json: ########## @@ -32,7 +32,9 @@ // records that cause the whole batch to be dropped. See KIP-467 for details. // // Version 9 enables flexible versions. - "validVersions": "0-9", + // + // Version 10 adds 'CurrentLeader' and 'NodeEndpoints' as tagged fields Review Comment: I was also wondering this and found the same discussion on the mailing thread. Ismael also +1'd this comment. I think generally we should have a strategy with respect to tagged fields. Should we always use the lowest tagged version? Should we only do that if older clients can use it/we backport changes for it? If we plan to bump on tagged fields is the only benefit that we save some bites over the wire in the case we don't always include the value in the response? (I'm also a bit unsure about the "saving bytes" here since we would just have an empty node endpoint array) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
