jolshan commented on code in PR #14444: URL: https://github.com/apache/kafka/pull/14444#discussion_r1348134556
########## clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java: ########## @@ -67,20 +69,31 @@ public ProduceResponse(ProduceResponseData produceResponseData) { */ @Deprecated public ProduceResponse(Map<TopicPartition, PartitionResponse> responses) { - this(responses, DEFAULT_THROTTLE_TIME); + this(responses, DEFAULT_THROTTLE_TIME, Collections.emptyList()); } /** - * Constructor for the latest version + * Constructor for versions <= 9 * @param responses Produced data grouped by topic-partition * @param throttleTimeMs Time in milliseconds the response was throttled */ @Deprecated public ProduceResponse(Map<TopicPartition, PartitionResponse> responses, int throttleTimeMs) { - this(toData(responses, throttleTimeMs)); + this(toData(responses, throttleTimeMs, Collections.emptyList())); + } + + /** + * Constructor for the latest version + * @param responses Produced data grouped by topic-partition + * @param throttleTimeMs Time in milliseconds the response was throttled + * @param nodeEndpoints List of node endpoints + */ + @Deprecated Review Comment: Taking a closer look, it looks like there was an effort to build the response directly and not pass in data structures (new maps) that will just be converted via toData. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org