chb2ab commented on code in PR #14444:
URL: https://github.com/apache/kafka/pull/14444#discussion_r1349137249


##########
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java:
##########
@@ -67,20 +69,31 @@ public ProduceResponse(ProduceResponseData 
produceResponseData) {
      */
     @Deprecated
     public ProduceResponse(Map<TopicPartition, PartitionResponse> responses) {
-        this(responses, DEFAULT_THROTTLE_TIME);
+        this(responses, DEFAULT_THROTTLE_TIME, Collections.emptyList());
     }
 
     /**
-     * Constructor for the latest version
+     * Constructor for versions <= 9
      * @param responses Produced data grouped by topic-partition
      * @param throttleTimeMs Time in milliseconds the response was throttled
      */
     @Deprecated
     public ProduceResponse(Map<TopicPartition, PartitionResponse> responses, 
int throttleTimeMs) {
-        this(toData(responses, throttleTimeMs));
+        this(toData(responses, throttleTimeMs, Collections.emptyList()));
+    }
+
+    /**
+     * Constructor for the latest version
+     * @param responses Produced data grouped by topic-partition
+     * @param throttleTimeMs Time in milliseconds the response was throttled
+     * @param nodeEndpoints List of node endpoints
+     */
+    @Deprecated

Review Comment:
   I started implementing this but I do think it's getting out of scope of this 
PR. 
[These](https://github.com/chb2ab/kafka/commit/e7bbd7b463db115e2f7b14618ea14da0ee893ae4)
 are my initial changes, to finish I think we want to remove PartitionResponse 
completely and replace it with PartitionProduceResponse, otherwise were just 
moving around the conversion. Having a deprecated constructor isn't ideal but I 
think we should remove it with KAFKA-10730, not this. @jolshan what do you 
think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to