jolshan commented on code in PR #14444: URL: https://github.com/apache/kafka/pull/14444#discussion_r1350511364
########## clients/src/main/resources/common/message/ProduceResponse.json: ########## @@ -32,7 +32,9 @@ // records that cause the whole batch to be dropped. See KIP-467 for details. // // Version 9 enables flexible versions. - "validVersions": "0-9", + // + // Version 10 adds 'CurrentLeader' and 'NodeEndpoints' as tagged fields Review Comment: Are we in agreement then that we should always bump the tagged field then? Unless we explicitly plan to backport the changes (ie what Jeff did for the consumer group changes?) I had some folks ask me what the correct protocol is, and it would be nice to give consistent answers 😅 ########## clients/src/main/resources/common/message/ProduceResponse.json: ########## @@ -32,7 +32,9 @@ // records that cause the whole batch to be dropped. See KIP-467 for details. // // Version 9 enables flexible versions. - "validVersions": "0-9", + // + // Version 10 adds 'CurrentLeader' and 'NodeEndpoints' as tagged fields Review Comment: Are we in agreement then that we should always bump the tagged field then? Unless we explicitly plan to backport the changes (ie what Jeff did for the consumer group changes?) I had some folks ask me what the correct protocol is, and it would be nice to give consistent answers 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
