philipnee commented on code in PR #14873:
URL: https://github.com/apache/kafka/pull/14873#discussion_r1416383477
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -103,6 +103,12 @@ public class HeartbeatRequestManager implements
RequestManager {
*/
private final BackgroundEventHandler backgroundEventHandler;
+ /**
+ * Timer for tracking the time since the last consumer poll. If the timer
expires, the consumer will stop
+ * sending heartbeat until the next poll.
+ */
Review Comment:
well, i'm not sure actually. According to KIP-848: `Static membership,
introduced in KIP-345, is still supported by this new rebalance protocol. When
a member wants to leave temporary – e.g. while being bounced – it should send
an heartbeat with a member epoch equals to -2. This signals to the group
coordinator that the member left but will rejoin within the session timeout.
When the member rejoins with the same instance ID, the group coordinator
replaces the old member by the new member and gives back its current
assignment.`
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -103,6 +103,12 @@ public class HeartbeatRequestManager implements
RequestManager {
*/
private final BackgroundEventHandler backgroundEventHandler;
+ /**
+ * Timer for tracking the time since the last consumer poll. If the timer
expires, the consumer will stop
+ * sending heartbeat until the next poll.
+ */
Review Comment:
well, i'm not sure actually. According to KIP-848: `Static membership,
introduced in KIP-345, is still supported by this new rebalance protocol. When
a member wants to leave temporary – e.g. while being bounced – it should send
an heartbeat with a member epoch equals to -2. This signals to the group
coordinator that the member left but will rejoin within the session timeout.
When the member rejoins with the same instance ID, the group coordinator
replaces the old member by the new member and gives back its current
assignment.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
