jolshan commented on code in PR #15685: URL: https://github.com/apache/kafka/pull/15685#discussion_r1594885949
########## server-common/src/main/java/org/apache/kafka/server/common/TestFeatureVersion.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.common; + +import java.util.List; + +public enum TestFeatureVersion implements FeatureVersion { + + TEST_0(0), + TEST_1(1), + TEST_2(2); + + private short featureLevel; + + public static final String FEATURE_NAME = "test.feature.version"; + public static final TestFeatureVersion PRODUCTION_VERSION = TEST_1; + + TestFeatureVersion(int featureLevel) { + this.featureLevel = (short) featureLevel; + } + + public short featureLevel() { + return featureLevel; + } + + public String featureName() { + return FEATURE_NAME; + } + + public void validateVersion(MetadataVersion metadataVersion, List<FeatureVersion> features) { + // version 1 depends on metadata.version 3.3-IVO + if (featureLevel >= 1 && metadataVersion.isLessThan(MetadataVersion.IBP_3_3_IV0)) + throw new IllegalArgumentException(FEATURE_NAME + " could not be set to " + featureLevel + + " because it depends on metadata.version=14 (" + MetadataVersion.IBP_3_3_IV0 + ")"); + } + + public static TestFeatureVersion metadataVersionMapping(MetadataVersion metadataVersion) { + if (metadataVersion.isLessThan(MetadataVersion.IBP_3_8_IV0)) { Review Comment: It's a little confusing, but the idea is that as long as the version is less than 3.8, we use 0 So for mv 3.3 -> 3.8 we will use test_0 The thing about 3.3, is that we can't set any version (test, transactions, etc, if the MV is < 3.3 since that is the version that introduced the feature records) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
