jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1597303887
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -258,6 +259,13 @@ public enum MetadataVersion {
this.didMetadataChange = didMetadataChange;
}
+ public String featureName() {
+ return FEATURE_NAME;
+ }
+
+ public void validateVersion(MetadataVersion metadataVersion,
List<FeatureVersion> features) {
+ }
Review Comment:
I removed this for now, we can add it back later if we want MetadataVersion
to implement our interface. I think there are pros and cons for doing so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
