jolshan commented on code in PR #15685: URL: https://github.com/apache/kafka/pull/15685#discussion_r1594886684
########## server-common/src/main/java/org/apache/kafka/server/common/TestFeatureVersion.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.common; + +import java.util.List; + +public enum TestFeatureVersion implements FeatureVersion { + + TEST_0(0), + TEST_1(1), + TEST_2(2); + + private short featureLevel; + + public static final String FEATURE_NAME = "test.feature.version"; + public static final TestFeatureVersion PRODUCTION_VERSION = TEST_1; + + TestFeatureVersion(int featureLevel) { + this.featureLevel = (short) featureLevel; + } Review Comment: yes, assuming we specify metadata version as a numerical value and not a string as it is done in many places in the code. as per the kip, validation may involve other features besides metadata version, so we will need to consider how that will be implemented. (I didn't have any example of such interdependence, but it was requested that I support it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
