jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1594889173
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -258,6 +259,13 @@ public enum MetadataVersion {
this.didMetadataChange = didMetadataChange;
}
+ public String featureName() {
+ return FEATURE_NAME;
+ }
+
+ public void validateVersion(MetadataVersion metadataVersion,
List<FeatureVersion> features) {
+ }
Review Comment:
Will do. I think the main thing was that that KafkaConfig can't be passed
due to directory structure. The important config is unstable version
enablement, so in a followup, I plan to include it in this method signature and
include logic to support unstable versioning for all versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
