jolshan commented on code in PR #15685: URL: https://github.com/apache/kafka/pull/15685#discussion_r1603375064
########## server-common/src/main/java/org/apache/kafka/server/common/FeatureVersionUtils.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.server.common; + +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +public interface FeatureVersionUtils { + + interface FeatureVersionImpl { + short featureLevel(); + + String featureName(); + + /** + * The next metadata version to be released when the feature became production ready. + * (Ie, if the current production MV is 17 when a feature is released, its mapping should be to MV 18) + */ + MetadataVersion metadataVersionMapping(); Review Comment: No. This is not the minimum version. This is the first **image version** that supports the feature. I wanted to have a mapping to image version, but that was heavily argued against on the mailing thread so I have to use MV as a proxy. This value is only a DEFAULT if no value is set during bootstrapping. As long at the feature is in the image, you can set it regardless of the MV set (production ready or not.) Setting the version is completely independent from the MV set. ########## server-common/src/main/java/org/apache/kafka/server/common/FeatureVersionUtils.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.server.common; + +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +public interface FeatureVersionUtils { + + interface FeatureVersionImpl { + short featureLevel(); + + String featureName(); + + /** + * The next metadata version to be released when the feature became production ready. + * (Ie, if the current production MV is 17 when a feature is released, its mapping should be to MV 18) + */ + MetadataVersion metadataVersionMapping(); Review Comment: No. This is not the minimum version. This is the first **image version** that supports the feature. I wanted to have a mapping to image version, but that was heavily argued against on the mailing thread so I have to use MV as a proxy. This value is only a DEFAULT if no value is set during bootstrapping but MV is set. As long at the feature is in the image, you can set it regardless of the MV set (production ready or not.) Setting the version is completely independent from the MV set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
