lucliu1108 commented on PR #20969: URL: https://github.com/apache/kafka/pull/20969#issuecomment-3824984085
Based on the Jira ticket([KAFKA-17251](https://issues.apache.org/jira/browse/KAFKA-17251)) there are 3 potential approaches to handle the KafkaStreams.cleanup() semantics. Since I'm not certain about which one is the best approach, will open up a discussion here: Approach 1. Delete the processId file during clean() explicityly before attempting to delete `app.dir`. - Potential pros: aligns with cleanUp semantics - Potential cons: after `cleanUp()` and starting with `initializeProcessId()` it will initialize a new processId, which breaks the processId persistence Approach 2. Preserve the processId and not logging a WARN for `app.dir` not delete (current implementation) - Potential pros: preseve the processId so the intance retains its identity - Potential cons: if other unexpected files remain in `app.dir`, this could hide potential problems Approach 3. Add a parameter for KafkaSteams#cleanUp() to decide whether to cleanup entirely or not (requires a KIP) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
