mjsax commented on PR #20969: URL: https://github.com/apache/kafka/pull/20969#issuecomment-3843424615
I guess we want to do option (2). But it's a question is we need KIP. Lucas argues we don't need one because "the code does this already". Not sure if I agree to this argument personally. From chickenchickenlove: > If the consensus is to preserve the metadata/process-id file, a small KIP + JavaDocs update seems like the cleanest way to make the contract explicit. Happy to draft it if folks agree. Seem there is no objection to do a small KIP. But it won't be about any logging changes, but about the contract change to not delete the whole "application directory", but to _empty_ the application directory with the exception of metadata file. What kind of logging we do at which level, is am impl detail only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
