lucasbru commented on PR #20969: URL: https://github.com/apache/kafka/pull/20969#issuecomment-3841211990
1) This PR looks useful to me. Avoid the warning sounds good, since things are working as intended, but I would still log at INFO level that we are keeping the directory due to the process ID file. I would also update the documentation to reflect the precise behavior of `cleanUp`. Since the behavior was effctively already the case, I don't think a KIP is necessary. 2) As a follow-up, we could add an argument to cleanUp in a KIP to fully delete the state directory. But I'm not convinced that we actually need this, so it would be low priority for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
