chickenchickenlove commented on PR #20969: URL: https://github.com/apache/kafka/pull/20969#issuecomment-3840984512
> Technically it says "delete all data" with would include the process-id file -- so strictly speaking it's a bug? -- But I do see the argument why we want to keep the file and not delete it: this would be technically an API contract change and might require a KIP (even if it might feel a little bit heavy). > > So I am still torn a little bit, but overall I tend to think: let's do a small KIP to document the change, and change the contract to keep the metadata file? This might be the cleanest solution? > +1 that we should align on the intended `KafkaStreams#cleanUp()` semantics first. The JavaDocs say “delete all data”, which would include the process-id file, so one could argue the current behavior is a bug — but changing it now may be an observable contract change for users relying on process-id persistence (KAFKA-10716). If the consensus is to preserve the metadata/process-id file, a small KIP + JavaDocs update seems like the cleanest way to make the contract explicit. Happy to draft it if folks agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
