cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784438707
##########
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala
##########
@@ -73,7 +74,7 @@ class BrokerMetadataListener(
/**
* The current metadata delta. Accessed only from the event queue thread.
*/
- private var _delta = new MetadataDelta(_image)
+ private var _delta = new MetadataDelta(_image, metadataVersionProvider)
Review comment:
The `MetadataImage` should have a metadata version associated with it.
So there is no need for the delta to have a "metadata version provider" since
the delta already knows what metadata version the image it is modifying is
based on.
if the version changes the interpretation of records we would certainly want
to make sure that we were using the correct one for the image we're modifying,
not something sourced from a global manager object somewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
