cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784434196
##########
File path: core/src/main/scala/kafka/server/ControllerServer.scala
##########
@@ -160,11 +160,24 @@ class ControllerServer(
alterConfigPolicy = Option(config.
getConfiguredInstance(AlterConfigPolicyClassNameProp,
classOf[AlterConfigPolicy]))
+ if (config.interBrokerProtocolVersionString !=
Defaults.InterBrokerProtocolVersion) {
+ // TODO can we have a stronger check here?
Review comment:
I think this check should be in KafkaConfig. It would also be stronger
to look at `KafkaConfig#originals` to verify that that we weren't trying to set
it to anything (i.e. ibp doesn't appear as a key in that map)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
