cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784428620



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/admin/UpdateFeaturesOptions.java
##########
@@ -26,4 +26,14 @@
  */
 @InterfaceStability.Evolving
 public class UpdateFeaturesOptions extends 
AbstractOptions<UpdateFeaturesOptions> {
+    private boolean dryRun = false;

Review comment:
       Looking at the other admin client things, it seems like we should 
probably name this `validateOnly` to be consistent with everything else. 
AlterClientQuotas, AlterConfigs, CreatePartitions, CreateTopics, all use 
`validateOnly` and not `dryRun`.
   
   (I guess this is a tiny KIP revision... but not too bad, right?)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to