cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784429730
##########
File path: clients/src/main/resources/common/message/UpdateFeaturesRequest.json
##########
@@ -30,7 +30,11 @@
{"name": "MaxVersionLevel", "type": "int16", "versions": "0+",
"about": "The new maximum version level for the finalized feature. A
value >= 1 is valid. A value < 1, is special, and can be used to request the
deletion of the finalized feature."},
{"name": "AllowDowngrade", "type": "bool", "versions": "0+",
- "about": "When set to true, the finalized feature version level is
allowed to be downgraded/deleted. The downgrade request will fail if the new
maximum version level is a value that's not lower than the existing maximum
finalized version level."}
- ]}
Review comment:
Yes. Just remove it if you are not using it any more.
The only awkward thing is that you need to think about how the defaults
work. I suppose it should be something like:
If AllowDowngrade = true (which would only be true for RPC version 0) then
force DowngradeType = SAFE. Otherwise default DowngradeType to NONE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
