[GitHub] [kafka] cmccabe commented on a change in pull request #11677: KAFKA-13410 Add KRaft metadata.version for KIP-778

[GitBox]

cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784427654



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##########
@@ -4245,12 +4245,24 @@ public UpdateFeaturesResult updateFeatures(final 
Map<String, FeatureUpdate> feat
                         new UpdateFeaturesRequestData.FeatureUpdateKey();
                     requestItem.setFeature(feature);
                     requestItem.setMaxVersionLevel(update.maxVersionLevel());
-                    requestItem.setAllowDowngrade(update.allowDowngrade());
+                    switch (update.downgradeType()) {
+                        case UNSET:
+                            // v0 behavior
+                            
requestItem.setAllowDowngrade(update.allowDowngrade());

Review comment:
       As described above, we can just condense this into `DowngradeType.SAFE`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org