On 2012.11.22 11:06, Toby Gray wrote: > I decided to go for a test directory as it turned into more than one file.
Fine with me. I'm not worried that much about where the code goes, as long as the code is in. > The current work in progress is on my (badly named) testing branch: > https://github.com/tobygray/libusbx/tree/testing > > It still needs some sort of test assert macro/function to clean up the > test code. I think I'll have to make use of setjmp and longjmp to get > this to work nicely though, so I was avoiding doing it for now. If you want some inspiration (though not with set/longjmp), libcdio is a library with fairly extensive testing [1]. These tests are POSIX centric (shell scripts that integrate with autotools), but I'd think that this is probably what we want as well. > I've also only added it to the Visual Studio 2005 build as I don't have > a copy of VC6 or VC2008 to test changes. No worries. At the risk of angering some people, I don't think it's worth spending any time on VC6 at this stage, as the return on (time) investment has ceased to be worth it, and we have better things to do... such as integrating WinCE support for instance (and I have to apologize again for the CE integration taking so darn long, but I'm still optimistic it will happen before the end of the year). > Currently test_stress.many_device_lists fails on Windows (as expected). > test_stress.default_context_change crashes on both Linux and Windows, > I've not yet looked into it in enough detail to see what the issue is, > but I think it's something to do with how the reference count works for > the default context. > > Does anyone have any comments on my approach or suggestions? At first glance, this looks OK to me, and I'll try to take a look at the Windows issue when I get a chance. Also since this work doesn't impact core or any of the backends, and we most certainly want it in our tree sooner rather than later, I don't see much of an issue with fast-tracking its integration into mainline sometime over the next couple of days, even if it's WIP with tests that fail, so that the remainder of the work is carried out directly against mainline. It may also help get more exposure, and maybe some additional help/comments. Regards, /Pete [1] http://git.savannah.gnu.org/gitweb/?p=libcdio.git;a=tree;f=test; ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
