On 25/11/12 01:45, Pete Batard wrote: > OK, the tests have now been pushed into mainline (as a single commit), > along with the 2 other commits that I said I'd be pushing some time ago.
Excellent. I'll try to find time to do some improvements and possibly even add some tests which perform some IO. My thinking for tests which require particular types of devices would be that they get marked as skipped if you don't have suitable devices connected. This would also including skipping tests when there are suitable devices but lacking suitable permissions (for usbfs on Linux) or suitable drivers (WinUSB not installed on Windows). > Toby: I renamed test_stress.c to stress.c, as I felt with the file > already residing in a tests/ subdirectory, it was a bit redundant, and I > applied some formatting changes (spaces -> tab). I hope that's OK with you. Good point about the name. Sorry about the spaces vs. tabs, I was switching between emacs in VM and MSVC 2005, both in their default indentation modes. I meant to correct the indentation once I'd got it all working, but obviously I forgot to! > From now on, you can submit patches against mainline for the test > feature. And thanks again for your work, as it's a most welcome feature. You mention 'submit patches', what is the preferred way to send code changes? Is it to attach patches to emails and or to link to branches in git repositories? Regards, Toby ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
