Dave Davey <[EMAIL PROTECTED]> writes:
> > Would it be a good idea (hack!) to do something like this somewhere in the
> > initialization of IrCOMM (ircomm_tty.c, ircomm_tty_open()?):
> >
> > tty->termios->c_iflag = 0;
> > tty->termios->c_oflag = 0;
> >
> > .. to force the ldisc into "raw" mode by default which is what we usually
> > want for IrCOMM and IrLPT? That way, we will not need to twiddle with
> > printcap etc.
>
> This would obviously solve a number of printer-related problems (or
> work around them?). I'm still puzzled that the old IrCOMM code seemed
> to correctly interpret the line flag ioctl's, whereas something now seems
> to be failing. CSLIP seems to be working well I hasten to add!
OK, so you are saying that the Takahides IrCOMM code did set the line
settings correctly. Not that I know how the serial driver (IrCOMM) can be
involved in the line-settings in any way (i and oflags) since this stuff
should be taken care of by the ldisc and tty.
But there are still code in my ircomm_tty_ioctl file which is still
disabled (non-ported), so I might have to take a look at it, to see if it
could effect the line settings in any way. I'll add the rest of the stuff,
just to be sure. One other thing is that I remove (deallocate) the driver
instance at close time. Maybe I should let it hang around until rmmod,
since some settings might get lost?
It might still be a good idea to always force the TTY into "raw" mode for
IrLPT, so users can have IrLPT working without any problems. The old IrLPT
impl from Thomas was impl. as a char device (not as a tty-driver) and did
therefore not have any linedisc at all. I still think the tty-driver
approach is a better way since it doesn't duplicate any code, althought it
becomes much more complex.
-- Dag
--
/ Dag Brattli | The Linux-IrDA Project /
// University of Tromsoe, Norway | Infrared communication for Linux //
/// http://www.cs.uit.no/~dagb | http://www.cs.uit.no/linux-irda/ ///
_______________________________________________
Linux-IrDA mailing list - [EMAIL PROTECTED]
http://www.pasta.cs.UiT.No/mailman/listinfo/linux-irda
