On 4/17/25 8:12 AM, Gokul Sriram Palanisamy wrote:
> Enable nodes required for q6 remoteproc bring up.
> 
> Signed-off-by: Gokul Sriram Palanisamy <[email protected]>
> ---

[...]

> +             apcs_glb: mailbox@f400004 {
> +                     compatible = "qcom,ipq5424-apcs-apps-global",
> +                                  "qcom,ipq6018-apcs-apps-global";
> +                     reg = <0 0x0f400004 0 0x6000>;

So either the offset in the driver is wrong, or the base here
is wrong

The IPC register is at 0x0f40000c

+ length is 0x10_000

[...]> +                        #clock-cells = <1>;
> +                     #mbox-cells = <1>;
> +             };
> +
> +             tmel_qmp: qmp@32090000 {
> +                     compatible = "qcom,ipq5424-tmel";
> +                     reg = <0 0x32090000 0 0x2000>;

0x4000-long, this should be much later on (sorted by unit address)

> +                     interrupts = <GIC_SPI 126 IRQ_TYPE_EDGE_RISING>;

I'm not a 100% sure this is the right interrupt, but I'm not saying
it's necessarily wrong

The rest looks ok

Konrad


Reply via email to