On 5/5/2025 6:37 PM, Konrad Dybcio wrote: > On 5/5/25 2:30 PM, Gokul Sriram P wrote: >> On 4/25/2025 5:17 PM, Konrad Dybcio wrote: >>> On 4/17/25 8:12 AM, Gokul Sriram Palanisamy wrote: >>>> From: Vignesh Viswanathan <[email protected]> >>>> >>>> Add support to bring up hexagon based WCSS using secure PIL. All IPQxxxx >>>> SoCs support secure Peripheral Image Loading (PIL). >>>> >>>> Secure PIL image is signed firmware image which only trusted software such >>>> as TrustZone (TZ) can authenticate and load. Linux kernel will send a >>>> Peripheral Authentication Service (PAS) request to TZ to authenticate and >>>> load the PIL images. This change also introduces secure firmware >>>> authentication using Trusted Management Engine-Lite (TME-L) which is >>>> supported on IPQ5424 SoC. This driver uses mailbox based PAS request to >>>> TME-L for image authentication if supported, else it will fallback to use >>>> SCM call based PAS request to TZ. >>>> >>>> In order to avoid overloading the existing WCSS driver or PAS driver, we >>>> came up with this new PAS based IPQ WCSS driver. >>>> >>>> Signed-off-by: Vignesh Viswanathan <[email protected]> >>>> Signed-off-by: Manikanta Mylavarapu <[email protected]> >>>> Signed-off-by: Gokul Sriram Palanisamy <[email protected]> >>>> --- >>> [...] >>> >>>> +static int wcss_sec_start(struct rproc *rproc) >>>> +{ >>>> + struct wcss_sec *wcss = rproc->priv; >>>> + struct device *dev = wcss->dev; >>>> + int ret; >>>> + >>>> + ret = qcom_q6v5_prepare(&wcss->q6); >>>> + if (ret) >>>> + return ret; >>>> + >>>> + if (!IS_ERR_OR_NULL(wcss->mbox_chan)) { >>> You abort probe if wcss->mbox_chan returns an errno, please rework >>> this to use if (use_tmelcom) or something >> Hi Konrad, >> >> do you mean to use 'use_tmelcom' variable from driver descriptor? If >> yes, what if mbox_request_channel( ) failed? >> >> or based on wcss->mbox_chan, should I set 'use_tmeeiihcckgddglcom' to >> true or false and use it? > Add 'use_tmelcom' in match data and then make decisions based on it > if the mailbox channel get fails and use_tmelcom is true, fail probing > etc.
Got it. Will update. Regards, Gokul
