On Fri, 23 Jun 2006, Paul Fulghum wrote: > On Fri, 2006-06-23 at 19:02 -0700, Greg KH wrote: > > That's all you have done here. Just moved the init to open, but this > > didn't change the logic at all as: > > > > > pl2303_set_termios (port, &tmp_termios); > > > > You then still call pl2303_set_termios(). How did this fix anything? > > It is not clear what code his patch is against. > It should not fix anything if made against 2.6.17
It was against 17-rc5, nothing changed under drivers/usb/serial between it and 17. Sorry for not specifying it. > I vaguely remember a patch to the console code that allocated the > dummy tty and termios for both the open and set_termios calls > in usb_console_setup. If his patch is against that, then maybe > the priv->termios_initialized is set in open and the correct > termios is set on the subsequent set_termios call from > usb_console_setup. I didn't see or cannot remember such a patch and in a freshly cloned Linus' tree in usb_console_setup ->open() is still called with ->tty = NULL. After that ->set_termios() is called with temporary tty and termios structures. Without my patch this is the first call to set_termios in pl2303 and the termios struct is overwritten with defaults (anybody has an idea why?) and the baudrate is set to 9600. AFAIU set_termios is called normally from ->open(), explicitely from ioctl(), or from usb_console_setup. So, apart from the latter case an ->open() always precedes ->set_termios(). Therefore moving that first time overwrite to ->open() should preserve the normal behaviour. Whereas with console ->open() in pl2303 returns immediately because ->tty = NULL, and now with this patch the subsequent call to ->set_termios() does set the correct baudrate. Thanks Guennadi --- Guennadi Liakhovetski Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
