On Sat, 2006-06-24 at 13:13 +0200, Guennadi Liakhovetski wrote: > Without my patch this is the first call to set_termios in pl2303 and the > termios struct is overwritten with defaults (anybody has an idea why?) and > the baudrate is set to 9600. AFAIU set_termios is called normally from > ->open(), explicitely from ioctl(), or from usb_console_setup. So, apart > from the latter case an ->open() always precedes ->set_termios(). > Therefore moving that first time overwrite to ->open() should preserve the > normal behaviour. Whereas with console ->open() in pl2303 returns > immediately because ->tty = NULL, and now with this patch the subsequent > call to ->set_termios() does set the correct baudrate.
OK, I get it. Moving the termios init from set_termios to open has the effect of never executing the termios init code for the console setup (in either open or set_termios). -- I don't know why this driver insists on overwriting an existing termios structure. It should use default settings or do nothing at all if termios == NULL, otherwise it should use the termios supplied to it. I think that code could simply be dropped. -- Paul Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
