On 27/01/14 20:03, Phoebe Buckheister wrote: > This patch set add support for the RF212 chip to the existing at86rf230 > driver, > and add various PHY parameters and netlink APIs to modify these parameters. > > Newly supported PHY parameters are: > * TX power control > * LBT mode for radios that support it (only in RF212 driver) > * CCA mode setting (only in RF212 driver) > * CCA energy detection levels (only in RF212 driver) > * autoack/autoretransmit by the radio itself (only in RF212 driver)
OK, I did a quick glance on first 4 patches. Please don't be too alarmed by amount of my notices. It is normal for a patch from new people to receive lots of small feedback. I hope to see a next respin really soon. I have a question regarding LBT. Isn't it just another clear channel assessment mode? Not from the terms in the standard maybe, but from the logical point of view. Another type would be ALOHA (IIRC), maybe some other types. What about adding single generic interface that will select between those channel availability check methods? Thus you would merge together patches #4 and #5 and replace them with a single generic API (I'm not so sure about patch #6 - set_cca_ed). Patch #7 is another topic. It is about MAC acceleration features. The problem is that this (potentially) clashes with multiple-interface-per-mac support. I will think later how to fit that in, ok? -- With best wishes Dmitry ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
