Am 15.05.2015 um 15:46 schrieb Stephan Witt <[email protected]>:

> Am 15.05.2015 um 14:49 schrieb Enrico Forestieri <[email protected]>:
> 
>> On Fri, May 15, 2015 at 12:04:50PM +0200, Stephan Witt wrote:
>>> 
>>> I'll try to get it running on Linux to see how it works there. Meanwhile,
>>> I'm interested in comments.
>> 
>> Please, don't pass back and forth QPixmap objects on the stack. These
>> are big objects, potentially. Instead, use
>> 
>> bool getPixmap(QString const & path, QPixmap & pm)
>> {
>>      // deal with QPixmap
>> 
>>      return !pm.isNull();
>> }
> 
> Ok, thank you. I'll change it.

This results in the following patch - if you had something like that in mind 
I'll
split it in two patches. The other getPixmap method with QPixmap result was 
already there.

Stephan

Attachment: 0003-svg-hidpi-on-mac.patch
Description: Binary data

Reply via email to