Re: 2.2

[Kornel Benko]

Am Sonntag, 17. Mai 2015 um 18:16:11, schrieb Stephan Witt <st.w...@gmx.net>
> Am 16.05.2015 um 15:58 schrieb Kornel Benko <kor...@lyx.org>:
> 
> > Am Samstag, 16. Mai 2015 um 15:22:03, schrieb Stephan Witt <st.w...@gmx.net>
> >>>>>> The SVG banner with design size 400x250 results in an pixmap of the 
> >>>>>> same size.
> >>>>>> This is not enough for HiDPI. So, I've made a "bigger" one to get a 
> >>>>>> crisp banner.
> >>>>> 
> >>>>> I think using the QSvgRenderer class to load SVG images for HiDPI is 
> >>>>> better.
> >>>>> I'll check it.
> >>>> 
> >>>> Hmm… this looks indeed better. But the Svg frame work is missing with 
> >>>> cmake. 
> >>>> Kornel, can you give a hint, please?
> >>>> 
> >>>> Stephan
> >>> 
> >>> I don't understand. I see no problems with cmake. At least on linux.
> >> 
> >> Sorry, this was a little bit terse indeed. In case I try to use 
> >> QSvgRenderer the header file is not found. The current code in master 
> >> doesn't use it ATM. But I don't know where the list of used frameworks is 
> >> defined for cmake. 
> >> 
> > 
> > I understand nothing about frameworks. Seaching for framework in 
> > lyx-cmake-files
> >     #find . -name CMakeLists.txt -or -name \*.cmake | xargs egrep -- 
> > -framework
> > gives
> >     ./development/cmake/modules/FindQt4.cmake:    
> > set(QT_GUI_LIB_DEPENDENCIES ${QT_GUI_LIB_DEPENDENCIES} "-framework Carbon" 
> > "-framework QuickTime")
> >     ./development/cmake/modules/FindQt4.cmake:    
> > set(QT_CORE_LIB_DEPENDENCIES ${QT_CORE_LIB_DEPENDENCIES} "-framework 
> > ApplicationServices")
> >     ./src/support/CMakeLists.txt:   target_link_libraries(support "objc" 
> > "-framework AppKit" "-framework CoreFoundation")
> >     ./src/CMakeLists.txt:           target_link_libraries(${_lyx} 
> > "-framework Cocoa")
> >     ./src/CMakeLists.txt:           target_link_libraries(${_lyx} 
> > "-framework AppKit")
> >     ./src/tex2lyx/CMakeLists.txt:   target_link_libraries(${_tex2lyx} 
> > "-framework AppKit")
> >     ./src/client/CMakeLists.txt:    target_link_libraries(${_lyxclient} 
> > "-framework AppKit")
> > 
> > 
> > Even in cmake own modules I cannot see any list.
> > (e.g. /usr/share/cmake*/Modules/*.cmake)
> 
> 
> I found it out. I was looking for qt_use_modules(frontend_qt Core Gui Widgets 
> …).
> One has to add Svg to this list.

Do we need to look for
        find_package(Qt5Svg QUIET) # or REQUIRED
in case of QT5?

> Stephan

        Kornel

signature.asc
Description: This is a digitally signed message part.