On Fri, Oct 23, 2015 at 07:31:49PM +0000, Guenter Milde wrote: > On 2015-10-23, Scott Kostyshak wrote: > > On Tue, Oct 20, 2015 at 09:10:05PM +0000, Guenter Milde wrote: > >> On 2015-10-20, Scott Kostyshak wrote: > >> > On Tue, Oct 20, 2015 at 07:16:44PM +0200, Günter Milde wrote: > >> >> commit 1523fc6023440f10ca0d82a681ded5c060d8fd33 > >> >> Author: Günter Milde <mi...@lyx.org> > >> >> Date: Tue Oct 20 19:14:39 2015 +0200 > > >> >> Partial fix for #9740 "XeTeX/LuaTeX with TeX fonts problems". > > >> >> Fixes output for 3 of the 4 test lyx-files. > > >> >> Includes "FIXME"s at places where further action is required to get > >> >> the XeTeX > >> >> export right but I don't know how. > >> >> ... > > >> >> + &&!runparams.isFullUnicode()) { // FIXME: check must be > >> >> done for useNonTeXFonts! > >> >> os << "\\inputencoding{utf8}\n" > >> >> << setEncoding("UTF-8"); > > >> > So to make sure I understand what you want with this FIXME is you would > >> > like to do something like params().useNonTeXFonts as you do in > >> > Buffer.cpp but in PDFOptions.cpp it's not clear how to access that? > > >> It may also be that I misunderstand what is done there, but basically, > >> yes: > >> I believe that the test at these places must be for "useNonTeXFonts" > >> instead > >> of "isFullUnicode", because XeTeX/LuaTeX with TeX fonts behave more similar > >> to 8-bit TeX regarding the in- and output encodings. > > > OK, what about the attached patch? Can you check that it does what you > > want as far as the two FIXMEs in PDFOptions.cpp? > > From what I see (and with my limited understanding of C++), I believe the > fix to be OK.
Has anything changed in the last couple of days? Specifically, are the commits 2aa65fdc and 36b9645b relevant to this discussion? If nothing has changed, then I will proceed to work on extending this patch to address the other FIXMEs that you added. Scott