João Luis Meloni Assirati <[EMAIL PROTECTED]> writes:

| Index: src/LaTeX.C
| ===================================================================
| --- src/LaTeX.C       (revision 13280)
| +++ src/LaTeX.C       (working copy)
| @@ -383,7 +383,8 @@
|  
|  int LaTeX::startscript()
|  {
| -     string tmp = cmd + ' ' + QuoteName(file) + " > " + os::nulldev();
| +     string tmp = cmd + (runparams.srcspecials?(' ' + 
lyxrc.source_specials_switch):"") +
| +             ' ' + QuoteName(file) + " > " + os::nulldev();

ostringstream perhaps? At least use temps/foramtting to make the line
look nicer.

| Index: src/converter.h
| ===================================================================
| --- src/converter.h   (revision 13280)
| +++ src/converter.h   (working copy)
| @@ -137,7 +138,7 @@
|                    std::string const & filename);
|       ///
|       bool runLaTeX(Buffer const & buffer, std::string const & command,
| -                   OutputParams const &);
| +                   std::string const & name, OutputParams const &);

Why not add the name to the OutputParams?
Is 'name' a nice name for this parameter?

|       ///
|       ConverterList converterlist_;
|       ///
| Index: src/lyxrc.C
| ===================================================================
| --- src/lyxrc.C       (revision 13280)
| +++ src/lyxrc.C       (working copy)
| @@ -280,6 +282,8 @@
|       preview = PREVIEW_OFF;
|       preview_hashed_labels  = false;
|       preview_scale_factor = "0.9";
| +     source_specials_switch = "";
| +     dvi_fwsearch_switch = "";

Not needed.

| Index: src/texrow.C
| ===================================================================
| --- src/texrow.C      (revision 13280)
| +++ src/texrow.C      (working copy)
| @@ -78,6 +78,39 @@
|  }
|  
|  
| +int TexRow::getRowFromId(int id, int pos) const
| +{
| +     RowList::const_iterator cit = rowlist.begin();
| +     int diff_id = abs(cit->id() - id);
| +     int best_id = cit->id();
| +     int diff_pos = abs(cit->pos() - pos);
| +     int best_row = cit->rownumber();
| +     while (cit != rowlist.end()) {
| +             ++cit;

This looks wrong. If cit == rowlist.end() - 1, then ++cit will bring
it to rowlist.end() and all operations on it will be bogus.

Please also change to use a for loop and don't reevaluate
rowlist.end() on each iteration.

-- 
        Lgb

Reply via email to